Add a dispatch for LinearAlgebra.norm2#2302
Draft
sharanry wants to merge 1 commit intoJuliaGPU:masterfrom
Draft
Conversation
`norm(@view x[..], 2)` was previously leading to a call of `LinearAlgebra.generic_norm2` which led to a scalar indexing. This catches such cuda subarray norm2 calls earlier. Inf-norm and p-norm with cuda subarrays still lead to the following dispatches: ```julia LinearAlgebra.generic_normInf(x) = float(mapreduce(norm, max, x)) LinearAlgebra.generic_norm1(x) = mapreduce(float ∘ norm, +, x) ``` I am not sure if there is a better way to dispatch the above. should resolve JuliaGPU#2280
sharanry
force-pushed
the
sy/strided_norm2
branch
from
413c397 to
0e2ef84
Compare
Member
|
What about generalizing the |
maleadt
force-pushed
the
master
branch
15 times, most recently
from
5d585c4 to
c850163
Compare
|
Hi, what's the status of this PR ? This issue is troublemsome for one of my code and I would like to know if the fix will be implemented into CUDA.jl |
Member
|
The PR fails CI, and there's an outstanding comment of mine, so it needs work I'd say. Feel free to take it up if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
norm(@view x[..], 2)was previously leading to a call ofLinearAlgebra.generic_norm2which led to a scalar indexing. This catches such cuda subarray norm2 calls earlier.Inf-norm and p-norm with cuda subarrays still lead to the following dispatches:
I am not sure if there is a better way to dispatch the above.
should resolve #2280